git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] config: clear the executable bits (if any) on $GIT_DIR/config

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 16, 2014, 18:49 UTC
Message-ID
<xmqqvbmfyo8w.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1416036379-4994-3-git-send-email-mhagger@alum.mit.edu>
Michael Haggerty <mhagger@alum.mit.edu> writes:
> There is no reason for $GIT_DIR/config to be executable, plus this
> change will help clean up repositories affected by the bug that was
> fixed by the previous commit.
I do not think we want to do this.

It is a welcome bugfix to create $GIT_DIR/config without executable bit when and only when we create it. It is very much in line with "There is no reason for $GIT_DIR/config to be executable"---we do not need to make it executable ourselves, so we shouldn't, but we did which was a bug we want to fix in patch 1/2 you posted.

But with the "preserve existing permissions" fix we did earlier, the end users are now allowed to flip the executable bit on for their own purpose, and dropping it without knowing why they are doing so is simply rude. And honestly, Git do *not* even want to know why the users want to flip the bit.

So I would suggest not to spend any cycle or any code complexity to "repair" existing repositories. Having that bit on does not hurt anybody. Those who found it curious can flip that bit off and then Git with "preserve existing permissions" fix will keep that bit off from then on.

Previous: Michael HaggertyNext: Michael Haggerty
Message 8 of 13 in “Don't make $GIT_DIR executable”
  1. 0/2 Don't make $GIT_DIR executableMichael Haggerty, Nov 15, 2014
  2. 1/2 create_default_files(): don't set u+x bit on $GIT_DIR/configMichael Haggerty, Nov 15, 2014
  3. Torsten BögershausenNov 15, 2014
  4. Michael HaggertyNov 16, 2014
  5. 2/2 config: clear the executable bits (if any) on $GIT_DIR/configMichael Haggerty, Nov 15, 2014
  6. Stefan BellerNov 15, 2014
  7. Michael HaggertyNov 15, 2014
  8. Junio C HamanoNov 16, 2014
  9. Michael HaggertyNov 17, 2014
  10. Junio C HamanoNov 17, 2014
  11. Michael HaggertyNov 17, 2014
  12. Eric WongNov 15, 2014
  13. Michael HaggertyNov 16, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.