Re: [PATCH v3] sha1_file: pass empty buffer to index empty file

From: Junio C Hamano <gitster@pobox.com>
Date: May 20, 2015, 17:03 UTC
Message-ID: <xmqqvbfnnpu6.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20150519221450.GB779@peff.net>

Jeff King <peff@peff.net> writes:

Show 12 quoted lines

> Your revised patch 2 looks good to me. I think you could test it more
> reliably by simply adding a larger file, like:
>
>   test-genrandom foo $((128 * 1024 + 1)) >big &&
>   echo 'big filter=epipe' >.gitattributes &&
>   git config filter.epipe.clean true &&
>   git add big
>
> The worst case if you get the size of the pipe buffer too small is that
> the test will erroneously pass, but that is OK. As long as one person
> has a reasonable-sized buffer, they will complain to the list
> eventually. :)

Yeah, I like it.  It was lazy of me not to add a new test.

Thanks.