Re: [PATCH v3] sha1_file: pass empty buffer to index empty file
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 19, 2015, 18:11 UTC
- Message-ID
- <xmqqk2w48mjp.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <20150519063716.GA22771@peff.net>
Jeff King <peff@peff.net> writes:
Show 29 quoted lines
> On Sun, May 17, 2015 at 12:10:49PM -0700, Junio C Hamano wrote: > >> I spoke too fast X-<. "while sh t0021-*.sh; do :; done" dies after >> a few iterations and with this squashed in it doesn't. >> >> t/t0021-conversion.sh | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/t/t0021-conversion.sh b/t/t0021-conversion.sh >> index 42e6423..b778faf 100755 >> --- a/t/t0021-conversion.sh >> +++ b/t/t0021-conversion.sh >> @@ -218,7 +218,7 @@ test_expect_success "filter: clean empty file" ' >> ' >> >> test_expect_success "filter: smudge empty file" ' >> - git config filter.empty-in-repo.clean true && >> + git config filter.empty-in-repo.clean "cat >/dev/null" && > > Hmm, I thought we turned off SIGPIPE when writing to filters these days. > Looks like we still complain if we get EPIPE, though. I feel like it > should be the filter's business whether it wants to consume all of the > input or not[1], and we should only be checking its exit status. > > -Peff > > [1] As a practical example, consider a file format that has a lot of > cruft at the end. The clean filter would want to read only to the > start of the cruft, and then stop for reasons of efficiency.
Yes. Let's do these two. The preparatory patch is larger than the real change.
-- >8 -- From: Junio C Hamano <gitster@pobox.com> Date: Tue, 19 May 2015 10:55:16 -0700 Subject: [PATCH] copy.c: make copy_fd() report its status silently
When copy_fd() function encounters errors, it emits error messages itself, which makes it impossible for callers to take responsibility for reporting errors, especially when they want to ignore certaion errors.
Move the error reporting to its callers in preparation.
- copy_file() and copy_file_with_time() by indirection get their own calls to error().
- hold_lock_file_for_append(), when told to die on error, used to exit(128) relying on the error message from copy_fd(), but now it does its own die() instead. Note that the callers that do not pass LOCK_DIE_ON_ERROR need to be adjusted for this change, but fortunately there is none ;-)
- filter_buffer_or_fd() has its own error() already, in addition to the message from copy_fd(), so this will change the output but arguably in a better way.
Signed-off-by: Junio C Hamano <gitster@pobox.com> --- cache.h | 4 ++++ copy.c | 17 +++++++++++------ lockfile.c | 2 +- 3 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/cache.h b/cache.h index 22b7b81..2981eec 100644 --- a/cache.h +++ b/cache.h @@ -1482,9 +1482,13 @@ extern const char *git_mailmap_blob; extern void maybe_flush_or_die(FILE *, const char *); __attribute__((format (printf, 2, 3))) extern void fprintf_or_die(FILE *, const char *fmt, ...); + +#define COPY_READ_ERROR (-2) +#define COPY_WRITE_ERROR (-3) extern int copy_fd(int ifd, int ofd); extern int copy_file(const char *dst, const char *src, int mode); extern int copy_file_with_time(const char *dst, const char *src, int mode); + extern void write_or_die(int fd, const void *buf, size_t count); extern int write_or_whine(int fd, const void *buf, size_t count, const char *msg); extern int write_or_whine_pipe(int fd, const void *buf, size_t count, const char *msg); diff --git a/copy.c b/copy.c index f2970ec..574fa1f 100644 --- a/copy.c +++ b/copy.c @@ -7,13 +7,10 @@ int copy_fd(int ifd, int ofd) ssize_t len = xread(ifd, buffer, sizeof(buffer)); if (!len) break; - if (len < 0) { - return error("copy-fd: read returned %s", - strerror(errno)); - } + if (len < 0) + return COPY_READ_ERROR; if (write_in_full(ofd, buffer, len) < 0) - return error("copy-fd: write returned %s", - strerror(errno)); + return COPY_WRITE_ERROR; } return 0; } @@ -43,6 +40,14 @@ int copy_file(const char *dst, const char *src, int mode) return fdo; } status = copy_fd(fdi, fdo); + switch (status) { + case COPY_READ_ERROR: + error("copy-fd: read returned %s", strerror(errno)); + break; + case COPY_WRITE_ERROR: + error("copy-fd: write returned %s", strerror(errno)); + break; + } close(fdi); if (close(fdo) != 0) return error("%s: close error: %s", dst, strerror(errno)); diff --git a/lockfile.c b/lockfile.c index 4f16ee7..beba0ed 100644 --- a/lockfile.c +++ b/lockfile.c @@ -206,7 +206,7 @@ int hold_lock_file_for_append(struct lock_file *lk, const char *path, int flags) int save_errno = errno; if (flags & LOCK_DIE_ON_ERROR) - exit(128); + die("failed to prepare '%s' for appending", path); close(orig_fd); rollback_lock_file(lk); errno = save_errno;
-- 2.4.1-413-ga38dc94