git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH 2/2] status: fix tests to handle new verbose git status during rebase

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 3, 2015, 18:25 UTC
Message-ID
<xmqqvbf4wswt.fsf@gitster.dls.corp.google.com>
In-Reply-To
<vpqmw0gadth.fsf@anie.imag.fr>
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
Show 8 quoted lines
> Guillaume Pagès <guillaume.pages@ensimag.grenoble-inp.fr> writes:
>
>> Signed-off-by: Guillaume Pagès <guillaume.pages@ensimag.grenoble-inp.fr>
>> ---
>>  t/t7512-status-help.sh | 227 ++++++++++++++++++++++++++++++++++++++++++++++---
>
> Your history is not bisectable if you sparate tests and code changes in
> two patches.
Yes.

And by squashing the two, you do not have to label 2/2 incorrectly as "fix tests"; it is merely fixing what 1/2 broke ;-)

> Plus, as a reviewer, I like seeing changes to the tests next to changes
> to the code, to show me what is the impact of the code change on the
> output of the program.

That too. is a very important consideration, maybe even more so than bisectability.

Thanks.
Previous: Matthieu MoyNext: Guillaume Pages
Message 4 of 7 in “status: give more information during rebase -i”
  1. 1/2 status: give more information during rebase -iGuillaume Pagès, Jun 3, 2015
  2. 2/2 status: fix tests to handle new verbose git status during rebaseGuillaume Pagès, Jun 3, 2015
  3. Matthieu MoyJun 3, 2015
  4. Junio C HamanoJun 3, 2015
  5. Guillaume PagesJun 3, 2015
  6. Matthieu MoyJun 3, 2015
  7. Matthieu MoyJun 3, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.