git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH 1/2] status: give more information during rebase -i

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Jun 3, 2015, 17:20 UTC
Message-ID
<vpqh9qobtf3.fsf@anie.imag.fr>
In-Reply-To
<1433320545-14244-1-git-send-email-guillaume.pages@ensimag.grenoble-inp.fr>
Guillaume Pagès <guillaume.pages@ensimag.grenoble-inp.fr> writes:
> +	if (!fclose(fp))
> +		strbuf_detach(&buf, NULL);
> +	else
> +		strbuf_release(&buf);

Why these two cases? Aren't you leaking the buffer when calling strbuf_detach and ignoring its return value?

(In general, there's not much to do when fclose fails actually)
-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Matthieu Moy
Message 7 of 7 in “status: give more information during rebase -i”
  1. 1/2 status: give more information during rebase -iGuillaume Pagès, Jun 3, 2015
  2. 2/2 status: fix tests to handle new verbose git status during rebaseGuillaume Pagès, Jun 3, 2015
  3. Matthieu MoyJun 3, 2015
  4. Junio C HamanoJun 3, 2015
  5. Guillaume PagesJun 3, 2015
  6. Matthieu MoyJun 3, 2015
  7. Matthieu MoyJun 3, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.