Re: [PATCH] Documentation/git-clean.txt: don't mention deletion of .git/modules/*

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 8, 2016, 22:22 UTC
Message-ID: <xmqqvb5y6dx2.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1454790889.23898.225.camel@mattmccutchen.net>

Matt McCutchen <matt@mattmccutchen.net> writes:

> I found no evidence of such behavior in the source code.
>
> Signed-off-by: Matt McCutchen <matt@mattmccutchen.net>
> ---

That was added last year at bcd57cb9 (Documentation/git-clean.txt: document that -f may need to be given twice, 2015-02-26). It would be better to know what got changed since then--that is, was the additional text unnecessary even back then, or we made changes to the system since then and forgot to remove the added text.

Mikko, is this need to give -f twice still the case?

Show 23 quoted lines

>
> This is based on the maint branch, a08595f.
>
>  Documentation/git-clean.txt | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/Documentation/git-clean.txt b/Documentation/git-clean.txt
> index 641681f..51a7e26 100644
> --- a/Documentation/git-clean.txt
> +++ b/Documentation/git-clean.txt
> @@ -37,9 +37,7 @@ OPTIONS
>  	to false, 'git clean' will refuse to delete files or directories
>  	unless given -f, -n or -i. Git will refuse to delete directories
>  	with .git sub directory or file unless a second -f
> -	is given. This affects also git submodules where the storage area
> -	of the removed submodule under .git/modules/ is not removed until
> -	-f is given twice.
> +	is given.
>  
>  -i::
>  --interactive::
> -- 
> 2.5.0