Re: [PATCH] Documentation/git-clean.txt: don't mention deletion of .git/modules/*

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 8, 2016, 23:50 UTC
Message-ID: <xmqq4mdi69ti.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1454971010.2511.89.camel@mattmccutchen.net>

Matt McCutchen <matt@mattmccutchen.net> writes:

Show 29 quoted lines

> On Mon, 2016-02-08 at 14:22 -0800, Junio C Hamano wrote:
>> Matt McCutchen <matt@mattmccutchen.net> writes:
>> 
>> > I found no evidence of such behavior in the source code.
>> > 
>> > Signed-off-by: Matt McCutchen <matt@mattmccutchen.net>
>> > ---
>> 
>> That was added last year at bcd57cb9 (Documentation/git-clean.txt:
>> document that -f may need to be given twice, 2015-02-26).  It would
>> be better to know what got changed since then--that is, was the
>> additional text unnecessary even back then, or we made changes to
>> the system since then and forgot to remove the added text.
>> 
>> Mikko, is this need to give -f twice still the case?
>
> I know you probably want confirmation from Mikko, but I'll offer my
> understanding.  There were two statements added in bcd57cb9:
>
> 1. -f may need to be given twice to delete nested worktrees and
> embedded repositories.  This is still true.
>
> 2. Deletion of submodule repositories under .git/modules is conditional
> on -f being given twice.  AFAICT, this was wrong even back then: "git
> clean" has never deleted such repositories under any conditions.
>
> My patch is only removing #2.
>
> Matt

Thanks for clarification.

"The latter half, the removal of the submodules, was never done with double -f back when the sentence was written, and we still do not do so." or "Back when the sentence was written, we used to require double -f, and we fixed that at commit X but forgot to update this text." are two possibilities, and either one explains and justifies this change even stronger than "There is no code to do such thing in today's version." and that is where my question came from.