git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 2/9] connect: only match the host with core.gitProxy

From
Junio C Hamano <gitster@pobox.com>
Date
May 16, 2016, 22:30 UTC
Message-ID
<xmqqvb2dzlee.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20160516000740.19042-3-mh@glandium.org>
Mike Hommey <mh@glandium.org> writes:
Show 5 quoted lines
> Currently, core.gitProxy doesn't actually match purely on domain names
> as documented: it also matches ports.
> ...
> This per-port behavior seems like an oversight rather than a deliberate
> choice, so, make git://kernel.org:port/path call the gitProxy script in

Hmph. The fact that hostandport, not just host after stripping possible ":port" part, is passed to the function smells like a deliberate design to allow people to use different proxy for different port, so I am not sure everybody agrees with your "seems like an oversight".

Don't existing users depend on the behaviour? Isn't the change robbing Peter to pay Paul?

Previous: Mike HommeyNext: Mike Hommey
Message 4 of 16 in “connect: various cleanups”
  1. 0/9 connect: various cleanupsMike Hommey, May 16, 2016
  2. 1/9 connect: call get_host_and_port() earlierMike Hommey, May 16, 2016
  3. 2/9 connect: only match the host with core.gitProxyMike Hommey, May 16, 2016
  4. Junio C HamanoMay 16, 2016
  5. Mike HommeyMay 16, 2016
  6. Junio C HamanoMay 16, 2016
  7. 3/9 connect: fill the host header in the git protocol with the host and port variablesMike Hommey, May 16, 2016
  8. 4/9 connect: make parse_connect_url() return separated host and portMike Hommey, May 16, 2016
  9. Junio C HamanoMay 16, 2016
  10. Mike HommeyMay 16, 2016
  11. 5/9 connect: group CONNECT_DIAG_URL handling codeMike Hommey, May 16, 2016
  12. 6/9 connect: make parse_connect_url() return the user part of the url as a separate valueMike Hommey, May 16, 2016
  13. 7/9 connect: change the --diag-url output to separate user and hostMike Hommey, May 16, 2016
  14. 8/9 connect: actively reject git:// urls with a user partMike Hommey, May 16, 2016
  15. Junio C HamanoMay 16, 2016
  16. 9/9 connect: move ssh command line preparation to a separate functionMike Hommey, May 16, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.