From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 16 May 2016 22:30:01 GMT
Subject: Re: [PATCH v5 2/9] connect: only match the host with core.gitProxy
Message-ID: <xmqqvb2dzlee.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160516000740.19042-3-mh@glandium.org>

Mike Hommey <mh@glandium.org> writes:

> Currently, core.gitProxy doesn't actually match purely on domain names
> as documented: it also matches ports.
> ...
> This per-port behavior seems like an oversight rather than a deliberate
> choice, so, make git://kernel.org:port/path call the gitProxy script in

Hmph.  The fact that hostandport, not just host after stripping
possible ":port" part, is passed to the function smells like a
deliberate design to allow people to use different proxy for
different port, so I am not sure everybody agrees with your "seems
like an oversight".

Don't existing users depend on the behaviour?  Isn't the change
robbing Peter to pay Paul?