Re: [PATCH v5 2/4] ls-files: optionally recurse into submodules
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 28, 2016, 22:22 UTC
- Message-ID
- <xmqqvaxfhdft.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <1475099443-145608-3-git-send-email-bmwill@google.com>
Brandon Williams <bmwill@google.com> writes:
> +--recurse-submodules:: > + Recursively calls ls-files on each submodule in the repository. > + Currently there is only support for the --cached mode.
Good to describe it, but at this step, there is only support for the "--cached" mode and it does not take a pathspec.
Also as the series progresses, I would expect this to be updated in patches $n/4 (2 < $n).
> + if (recurse_submodules && argc)
> + die("ls-files --recurse-submodules does not support path "
> + "arguments");Hmm, s/path arguments/pathspec/, perhaps, as the latter is specified in the glossary?