Re: [PATCH v7 0/4] recursive support for ls-files
- From
Stefan Beller <sbeller@google.com>
- Date
- Oct 7, 2016, 18:34 UTC
- Message-ID
- <CAGZ79kacgsPg-dzx7JRyhA2bq9JMb2Cyg9PjWbnKi9ZMTPw7RQ@mail.gmail.com>
- In-Reply-To
- <20161007181851.15063-1-bmwill@google.com>
On Fri, Oct 7, 2016 at 11:18 AM, Brandon Williams <bmwill@google.com> wrote:
> Few minor fixes pointed out Stefan
Nit: This is not very informative, so you could provide an "interdiff" to the last patch, (see https://github.com/trast/tbdiff for a sophisticated tool, I usually do a git diff origin/sb/<what-junio-queued>) That helps reviewers as they do not need to review it all again, but they may remember what they annotated and see how you addressed it.
Thanks, Stefan