git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] archive-tar: fix a sparse 'constant too large' warning

From
Junio C Hamano <gitster@pobox.com>
Date
May 9, 2017, 23:36 UTC
Message-ID
<xmqqvap9zjpc.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<4bf9be3c-5d19-09e3-b8b3-dd58e00e623d@ramsayjones.plus.com>
Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
Show 5 quoted lines
> In a similar vein, on systems which use a 64-bit representation of the
> 'unsigned long' type, the USTAR_MAX_SIZE constant macro is defined with
> the value 077777777777ULL. Although this does not cause any warning
> messages to be issued, it would be more appropriate for this constant
> to use an 'UL' type suffix rather than 'ULL'.

... it is more appropriate because we know the recipient is "unsigned long", not "unsigned long long", in this case? As opposed to the case of timestamp_t, which is opaque and could be "unsigned long long"?

That makes sense to me, even though it took a bit of thinking aloud to understand.

Looks good; thanks.
Previous: Johannes Schindelin
Message 6 of 6 in “archive-tar: fix a sparse 'constant too large' warning”
  1. archive-tar: fix a sparse 'constant too large' warningRamsay Jones, May 8, 2017
  2. Johannes SchindelinMay 9, 2017
  3. Ramsay JonesMay 9, 2017
  4. Junio C HamanoMay 9, 2017
  5. Johannes SchindelinMay 10, 2017
  6. Junio C HamanoMay 9, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.