git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] archive-tar: fix a sparse 'constant too large' warning

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
May 10, 2017, 10:55 UTC
Message-ID
<alpine.DEB.2.21.1.1705101254440.146734@virtualbox>
In-Reply-To
<xmqqr2zxzjf9.fsf@gitster.mtv.corp.google.com>
Hi Junio,
On Wed, 10 May 2017, Junio C Hamano wrote:
Show 14 quoted lines
> Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
> 
> > Yeah, I had a similar comment in the commit message (but much more
> > verbose than your concise addition above), but I edited it several
> > times, without finding a wording that I liked. I eventually removed
> > it, because it didn't really add any value. :(
> 
> I tend to agree that the proposed additional comment does not add much
> value.  It assures the readers that we (at the time of applying this
> patch) know that the earlier use of ULL was not done with a good reason
> but was merely an accident, and strengthens the claim that this is a
> good change, but the correctness of the change is already obvious, and
> the readers would understand without being explained where the
> incorrectness we have to fix with this patch came from, I would think.

Future me would find that comment in the commit message very clarifying, though: why was that code there? Ah, that's why.

Now I have to dig through the mailing list to find out.

Ciao, Dscho

Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 6 in “archive-tar: fix a sparse 'constant too large' warning”
  1. archive-tar: fix a sparse 'constant too large' warningRamsay Jones, May 8, 2017
  2. Johannes SchindelinMay 9, 2017
  3. Ramsay JonesMay 9, 2017
  4. Junio C HamanoMay 9, 2017
  5. Johannes SchindelinMay 10, 2017
  6. Junio C HamanoMay 9, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.