Re: [PATCH v2 2/5] Makefile: under "make dist", include the sha1collisiondetection submodule

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 8, 2017, 22:48 UTC
Message-ID: <xmqqvahg6dkc.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171208223001.556-3-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

Show 5 quoted lines

> Include the sha1collisiondetection submodule when running "make
> dist". Even though we've been shipping the sha1collisiondetection
> submodule[1] and using it by default if it's checked out[2] anyone
> downloading git as a tarball would just get an empty
> sha1collisiondetection/ directory.

While I can see that you are not including everything, but I do not see _why_ you chose to do so and hardcode the burden of maintaining the list of files we need to copy in the Makefile.

This is much better than shipping a tarball that would not build at the endgame stage, of course ;-)

Thanks.