Re: [PATCH 4/4] sha1dc: remove in favor of using sha1collisiondetection as a submodule

From: Jeff King <peff@peff.net>
Date: Dec 5, 2017, 07:10 UTC
Message-ID: <20171205071010.GD4788@sigill.intra.peff.net>
In-Reply-To: <20171128213214.12477-5-avarab@gmail.com>

On Tue, Nov 28, 2017 at 09:32:14PM +0000, Ævar Arnfjörð Bjarmason wrote:

> As an aside: Now where was that .gitdiffsort or whatever it was called
> which would enable us to show sha1dc_git.h before nuking the contents
> of sha1dc? :)

diff.orderFile, I think.

> It also occurs to me that it would be useful for patch formatting in
> general to make all file removals go after file changes & additions.

I wonder if that might run afoul of programs which try to apply patches in order. I think "git apply" is smart enough to apply all deletions (regardless of order) before any creations (so it cannot be fooled by adding "foo" followed by deleting "foo/bar"). So maybe it's fine.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.