Re: [PATCH v4 8/7] wildmatch test: skip file creation tests on Windows proper

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 8, 2018, 18:49 UTC
Message-ID: <xmqqvagc89ti.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <87mv1raz9p.fsf@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 13 quoted lines

> I agree that there should be some prerequisite to skip this on Windows
> by default since 6 minutes is clearly excessive (although I think you'll
> find it runs a bit faster in the branch above), but that should be
> something like:
>
>     test_lazy_prereq EXPENSIVE_ON_WINDOWS '
>             test -n "$GIT_TEST_LONG" || test_have_prereq !MINGW,!CYGWIN
>     '
>
> As the long runtime is not inherent to the test, but to excessive
> slowness caused by certain operations on certain platforms, or maybe it
> should be EXPENSIVE_ON_SLOW_FS or EXPENSIVE_IF_FORKING_IS_SLOW or if
> we'd like to generalize it.

We already do skip overly long tests everywhere unless explicitly asked to run them, and the above sounds like a good way to go.