Re: [PATCH v4 8/7] wildmatch test: skip file creation tests on Windows proper

From: Duy Nguyen <pclouds@gmail.com>
Date: Jan 7, 2018, 02:51 UTC
Message-ID: <CACsJy8CDz57RR+VHpaPb5YMhKG5kUgb9rt5TWKL8n+e7Xart3g@mail.gmail.com>
In-Reply-To: <nycvar.QRO.7.76.6.1801061337020.1337@wbunaarf-fpuvaqryva.tvgsbejvaqbjf.bet>

On Sat, Jan 6, 2018 at 7:51 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 15 quoted lines

> Nobody likes to run tests that take too
> long. And look at this:
>
>         ...
>         ok 1511 - ipathmatch: match 'Z' '[Z-y]'
>         ok 1512 - ipathmatch(ls): match '[Z-y]' 'Z'
>         # still have 84 known breakage(s)
>         # failed 52 among remaining 1428 test(s)
>         1..1512
>
>         real    5m51.432s
>         user    0m33.986s
>         sys     2m13.162s
>
> Yep. It takes *over eight minutes*.

I suppose this is because the sheer number of test cases adds a lot of shell overhead on Windows. I wonder if it's better to rewrite this test in C instead. We start to do some more unit testing here and there and kind of abuse the sh-based test framework for this. Having a proper unit test framework would be good anyway since it's sometimes hard to create a specific scenario with high level commands.

-- 
Duy