Re: [PATCH v3 5/7] gpg-interface: introduce new config to select per gpg format program
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 16, 2018, 20:45 UTC
- Message-ID
- <xmqqva9esydn.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <8e6f4f547475e3ce26799901e255a78ea74dac8e.1531470729.git.henning.schild@siemens.com>
Henning Schild <henning.schild@siemens.com> writes:
> +gpg.<format>.program:: > + Use this to customize the program used for the signing format you > + chose. (see gpg.program) gpg.openpgp.program is a synonym for the > + legacy gpg.program.
I _think_ you meant "see gpg.format", but I am not 100% sure.
When X is a synonym for Y, Y is also a synonym for X, so technically speaking this does not matter, but when we talk about backward compatibility fallback, I think we say "OLDway is retained as a legacy synonym for NEWway", i.e. the other way around.
Also, `typeset in tt` what end-users would type literally, like configuration variable names, i.e.
Use this to customize the rpogram used for the signing format you chose (see `gpg.format`). `gpg.program` can still be used as a legacy synonym for `gpg.openpgp.program`.
Show 16 quoted lines
> gui.commitMsgWidth::
> Defines how wide the commit message window is in the
> linkgit:git-gui[1]. "75" is the default.
> diff --git a/gpg-interface.c b/gpg-interface.c
> index 93bd0fb32..f3c22b551 100644
> --- a/gpg-interface.c
> +++ b/gpg-interface.c
> @@ -182,7 +182,7 @@ int git_gpg_config(const char *var, const char *value, void *cb)
> return 0;
> }
>
> - if (!strcmp(var, "gpg.program"))
> + if (!strcmp(var, "gpg.program") || !strcmp(var, "gpg.openpgp.program"))
> fmtname = "openpgp";
>
> if (fmtname) {