Re: [PATCH v3 1/7] gpg-interface: add new config to select how to sign a commit

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Jul 17, 2018, 00:03 UTC
Message-ID: <20180717000310.GA980821@genre.crustytoothpaste.net>
In-Reply-To: <5e88da5eac1e1aea8a946960d455ba321e3e42b1.1531470729.git.henning.schild@siemens.com>

On Fri, Jul 13, 2018 at 10:41:23AM +0200, Henning Schild wrote:

Show 21 quoted lines

> Add "gpg.format" where the user can specify which type of signature to
> use for commits. At the moment only "openpgp" is supported and the value is
> not even used. This commit prepares for a new types of signatures.
> 
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>  Documentation/config.txt | 4 ++++
>  gpg-interface.c          | 7 +++++++
>  2 files changed, 11 insertions(+)
> 
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index 1cc18a828..ac373e3f4 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -1828,6 +1828,10 @@ gpg.program::
>  	signed, and the program is expected to send the result to its
>  	standard output.
>  
> +gpg.format::
> +	Specifies which key format to use when signing with `--gpg-sign`.
> +	Default is "openpgp", that is also the only supported value.

I think, as discussed in the other thread, perhaps a different prefix for these options is in order if we'd like to plan for the future. Maybe this could be "signature.format", "sign.format", "signing.format", or "signingtool.format" (I tend to prefer the former, but not too strongly).

I anticipate that some projects will prefer other formats, and it makes it easier if we don't have to maintain two sets of legacy names.

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204