Re: [PATCH v3 0/2] rebase -i: introduce the 'break' command

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 12, 2018, 14:01 UTC
Message-ID: <xmqqva679sc8.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <pull.43.v3.git.gitgitgadget@gmail.com>

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 6 quoted lines

> This patch introduces that, based on ag/rebase-i-in-c.
>
> Changes since v2:
>
>  * Fixed two typos.
>  * When interrupting the rebase, break now outputs a message.

I was about to merge the whole collection of topics to 'next', but this came to stop me just in time.

The typofixes are appreciated of course, and look trivially correct.

I find that the if() condition that does too many side-effect-full operations in stopped-at-head shows bad taste. It is still short enough to understand what each step is trying to do, but would encourage others who later may touch the code to make it even more complex.

But it is a short and isolated static helper function, so I won't complain too loudly.

Will replace and requeue.

Thanks.