Re: [PATCH v3 0/2] rebase -i: introduce the 'break' command
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Oct 12, 2018, 15:32 UTC
- Message-ID
- <nycvar.QRO.7.76.6.1810121732240.561@tvgsbejvaqbjf.bet>
- In-Reply-To
- <xmqqva679sc8.fsf@gitster-ct.c.googlers.com>
Hi Junio,
On Fri, 12 Oct 2018, Junio C Hamano wrote:
Show 25 quoted lines
> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> > writes: > > > This patch introduces that, based on ag/rebase-i-in-c. > > > > Changes since v2: > > > > * Fixed two typos. > > * When interrupting the rebase, break now outputs a message. > > I was about to merge the whole collection of topics to 'next', but > this came to stop me just in time. > > The typofixes are appreciated of course, and look trivially correct. > > I find that the if() condition that does too many side-effect-full > operations in stopped-at-head shows bad taste. It is still short > enough to understand what each step is trying to do, but would > encourage others who later may touch the code to make it even more > complex. > > But it is a short and isolated static helper function, so I won't > complain too loudly. > > Will replace and requeue.
Thanks, Dscho
> > Thanks. >