Re: [PATCH] read-cache: use of memory after it is freed

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 22, 2018, 03:39 UTC
Message-ID: <xmqqva5uwsyd.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CACsJy8B8q84=AqMvAkc5=oSPBbwMQkdQhRe=RYVKGYmnsGxVGA@mail.gmail.com>

Duy Nguyen <pclouds@gmail.com> writes:

Show 8 quoted lines

>>         freshen_shared_index(base_path, 0);
>>         merge_base_index(istate);
>>         post_read_index_from(istate);
>> -       free(base_path);
>>         trace_performance_leave("read cache %s", base_path);
>> +       free(base_path);
>
> Oops. Ack.

Thanks, both.

>> introduced with c46c406ae1e (trace.h: support nested performance tracing)
>> on Aug 18, 2018 but not affecting maint

Yup. The series nd/unpack-trees-with-cache-tree however was designed to be merge-able down to 'maint', so it is a good idea to fix this at the tip of the topic. So I'll queue it on top of 5f4436a7 ("Document update for nd/unpack-trees-with-cache-tree", 2018-08-25).