threads / patch / 49623

patchread-cache: use of memory after it is freed

Subject: [PATCH] read-cache: use of memory after it is freed

## tl;dr

3 messages between Oct 20, 2018 and Oct 22, 2018. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Carlo Marcelo Arenas Belón· Oct 20, 2018, 07:33 UTC · lore

introduced with c46c406ae1e (trace.h: support nested performance tracing) on Aug 18, 2018 but not affecting maint

Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
---
 read-cache.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to read-cache.c +1 −1

diff --git a/read-cache.c b/read-cache.c
index 1df5c16dbc..78f47d2f50 100644
--- a/read-cache.c
+++ b/read-cache.c
@@ -2297,8 +2297,8 @@ int read_index_from(struct index_state *istate, const char *path,
 	freshen_shared_index(base_path, 0);
 	merge_base_index(istate);
 	post_read_index_from(istate);
-	free(base_path);
 	trace_performance_leave("read cache %s", base_path);
+	free(base_path);
 	return ret;
 }

-- 
2.19.1

Duy Nguyen· Oct 20, 2018, 15:15 UTC · re: Carlo Marcelo Arenas Belón · lore

Re: [PATCH] read-cache: use of memory after it is freed

On Sat, Oct 20, 2018 at 9:33 AM Carlo Marcelo Arenas Belón <carenas@gmail.com> wrote:

Show 20 quoted lines

>
> introduced with c46c406ae1e (trace.h: support nested performance tracing)
> on Aug 18, 2018 but not affecting maint
>
> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
> ---
>  read-cache.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/read-cache.c b/read-cache.c
> index 1df5c16dbc..78f47d2f50 100644
> --- a/read-cache.c
> +++ b/read-cache.c
> @@ -2297,8 +2297,8 @@ int read_index_from(struct index_state *istate, const char *path,
>         freshen_shared_index(base_path, 0);
>         merge_base_index(istate);
>         post_read_index_from(istate);
> -       free(base_path);
>         trace_performance_leave("read cache %s", base_path);
> +       free(base_path);

Oops. Ack.

Show 6 quoted lines

>         return ret;
>  }
>
> --
> 2.19.1
>

-- 
Duy

Junio C Hamano· Oct 22, 2018, 03:39 UTC · re: Duy Nguyen · lore

Re: [PATCH] read-cache: use of memory after it is freed

Duy Nguyen <pclouds@gmail.com> writes:

Show 8 quoted lines

>>         freshen_shared_index(base_path, 0);
>>         merge_base_index(istate);
>>         post_read_index_from(istate);
>> -       free(base_path);
>>         trace_performance_leave("read cache %s", base_path);
>> +       free(base_path);
>
> Oops. Ack.

Thanks, both.

>> introduced with c46c406ae1e (trace.h: support nested performance tracing)
>> on Aug 18, 2018 but not affecting maint

Yup. The series nd/unpack-trees-with-cache-tree however was designed to be merge-able down to 'maint', so it is a good idea to fix this at the tip of the topic. So I'll queue it on top of 5f4436a7 ("Document update for nd/unpack-trees-with-cache-tree", 2018-08-25).