git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] t4253-am-keep-cr-dos: avoid using pipes

From
Junio C Hamano <gitster@pobox.com>
Date
May 8, 2019, 05:49 UTC
Message-ID
<xmqqv9ylh4wl.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<CALM0=-=5WeTJ2-r+u-8TYzOAih_3aCEESSpA4oKhxjRpK2yj6w@mail.gmail.com>
"LI, BO XUAN" <liboxuan@connect.hku.hk> writes:
> Thanks for your review! I can understand your point, but I've got a
> quick question:
>
> What if format-patch really breaks and 'am' magically does not break?

Doesn't that indicate that you are not testing the result of "am" adequately?

I am not saying it is *wrong* to split the pipe into two. I am merely saying that it is borderline Meh, as the primary point of these two tests are to see how the command downstream of the pipe behaves and not the upstream one.

Previous: LI, BO XUANNext: LI, BO XUAN
Message 4 of 5 in “t4253-am-keep-cr-dos: avoid using pipes”
  1. t4253-am-keep-cr-dos: avoid using pipesBoxuan Li, May 5, 2019
  2. Junio C HamanoMay 7, 2019
  3. LI, BO XUANMay 7, 2019
  4. Junio C HamanoMay 8, 2019
  5. LI, BO XUANMay 8, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.