Re: [PATCH v3 2/3] bundle-create: progress output control

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 11, 2019, 09:01 UTC
Message-ID: <xmqqv9rqhjly.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20191111081047.GA17861@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 15 quoted lines

> On Mon, Nov 11, 2019 at 07:28:55AM +0000, Robin H. Johnson wrote:
>
>> > Do we need all four of these?
>> I copied the exact set of messages from git-pack-objects, and I do think
>> the same set makes sense specifically to mirror pack-objects for the
>> moment.
>
> I'm not sure I agree. In what situation would anybody use "git bundle
> create --all-progress-implied", for example? Literally no other Git
> command except pack-objects has "--all-progress" or
> "--all-progress-implied" (even ones which call pack-objects under the
> hood to print the progress!), and the presence of the latter in
> pack-objects is due to a backwards-compatibility thing in the early days
> (where --all-progress did too many things, but we could no longer change
> it). I think it would be a mistake to spread it further.

I am quite cure I agree with your reasoning that we would want to limit the "--all-progress-implied" craziness from spreading ;-)

Thanks.