Re: [PATCH v3 3/3] bundle-verify: add --quiet

From: Jeff King <peff@peff.net>
Date: Nov 11, 2019, 04:09 UTC
Message-ID: <20191111040938.GC6379@sigill.intra.peff.net>
In-Reply-To: <20191110204126.30553-3-robbat2@gentoo.org>

On Sun, Nov 10, 2019 at 12:41:26PM -0800, Robin H. Johnson wrote:

Show 11 quoted lines

> @@ -97,8 +97,11 @@ static int cmd_bundle_create(int argc, const char **argv, const char *prefix) {
>  static int cmd_bundle_verify(int argc, const char **argv, const char *prefix) {
>  	struct bundle_header header;
>  	int bundle_fd = -1;
> +	int quiet = 0;
>  
>  	struct option options[] = {
> +		OPT_BOOL('q', "quiet", &quiet,
> +			    N_("do not show bundle details")),
>  		OPT_END()
>  	};

This --quiet makes much more sense to me (compared to the last patch) as distinct from "--no-progress", because it is about quieting non-progress chatter.

There's an OPT__QUIET() macro; should we be using that here?

-Peff