Re: [PATCH v3 2/2] log: add log.excludeDecoration config option
Derrick Stolee <stolee@gmail.com> writes:
Show 22 quoted lines
> On 4/16/2020 2:03 PM, Junio C Hamano wrote:
>> Junio C Hamano <gitster@pobox.com> writes:
>>
>>>> if (include_patterns && include_patterns->nr) {
>>>> - int found = 0;
>>>> for_each_string_list_item(item, include_patterns) {
>>>> if (match_ref_pattern(refname, item)) {
>>>> - found = 1;
>>>> - break;
>>>> + return 1;
>>>> }
>>>
>>> Micronit.
>>>
>>> Let's mimick the early return in the loop above (for command line
>>> excludes) and below (for configured excludes), each of which is just
>>> a single "return" statement in a block without {braces} around.
>>
>> ... heh, it seems that the nit is mine in the suggested alternative
>> upthread. Let me amend while queuing.
>
> Shame on me for not noticing. Thanks for the close look!Heh, shame is mine, too ;-)
Thanks.
Junio C Hamano <gitster@pobox.com>