Re: [PATCH v3 2/2] log: add log.excludeDecoration config option
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 16, 2020, 18:03 UTC
- Message-ID
- <xmqqftd3z4sa.fsf@gitster.c.googlers.com>
- In-Reply-To
- <xmqqo8rrz5gn.fsf@gitster.c.googlers.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 14 quoted lines
>> if (include_patterns && include_patterns->nr) {
>> - int found = 0;
>> for_each_string_list_item(item, include_patterns) {
>> if (match_ref_pattern(refname, item)) {
>> - found = 1;
>> - break;
>> + return 1;
>> }
>
> Micronit.
>
> Let's mimick the early return in the loop above (for command line
> excludes) and below (for configured excludes), each of which is just
> a single "return" statement in a block without {braces} around.... heh, it seems that the nit is mine in the suggested alternative upthread. Let me amend while queuing.
Thanks.