Re: [PATCH 1/2] t5534: new test case for atomic signed push

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 15, 2020, 20:31 UTC
Message-ID: <xmqqv9gezsr9.fsf@gitster.c.googlers.com>
In-Reply-To: <20200915095827.52047-1-hanxin.hx@alibaba-inc.com>

Han Xin <chiyutianyi@gmail.com> writes:

Show 5 quoted lines

> In order to test signed atomic push, add a new test case.
>
> Reviewed-by: Jiang Xin <zhiyou.jx@alibaba-inc.com>
> Signed-off-by: Han Xin <hanxin.hx@alibaba-inc.com>
> ---

Thanks, but nowhere in the above it does not say what is being tested. By looking at 2/2 (by the way, these should be a single atomic patch, not a "failure turns into success", as it is not even a bug fix), readers may be able to guess that you want to enforce that with even broken implementation of GPG, an immediate failure to push one of the refs will be noticed by looking at their refs, but it is unclear why that is even desirable---if you combine the two patches, you may have a better place to argue why it is a good idea, but a test-only patch makes it even less clear why the new behavior expected by this test is desirable.

Show 29 quoted lines

>  t/t5534-push-signed.sh | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/t/t5534-push-signed.sh b/t/t5534-push-signed.sh
> index 030331f1c5..d0fcdc900e 100755
> --- a/t/t5534-push-signed.sh
> +++ b/t/t5534-push-signed.sh
> @@ -273,4 +273,21 @@ test_expect_success GPGSM 'fail without key and heed user.signingkey x509' '
>  	test_cmp expect dst/push-cert-status
>  '
>  
> +test_expect_failure GPG 'check atomic push before running GPG' '
> +	prepare_dst &&
> +	git -C dst config receive.certnonceseed sekrit &&
> +	write_script gpg <<-EOF &&
> +	echo >&2 "Fake gpg is called."
> +	exit 1
> +	EOF
> +	test_must_fail env PATH="$TRASH_DIRECTORY:$PATH" git push --signed --atomic \
> +			dst noop ff noff >out 2>&1 &&
> +	grep "^error:" out >actual &&
> +	cat >expect <<-EOF &&
> +	error: atomic push failed for ref refs/heads/noff. status: 2
> +	error: failed to push some refs to '"'"'dst'"'"'
> +	EOF
> +	test_i18ncmp expect actual
> +'
> +
>  test_done