Re: [PATCH 1/2] t5534: new test case for atomic signed push

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 15, 2020, 20:34 UTC
Message-ID: <xmqqr1r2zslr.fsf@gitster.c.googlers.com>
In-Reply-To: <20200915095827.52047-1-hanxin.hx@alibaba-inc.com>

Han Xin <chiyutianyi@gmail.com> writes:

Show 5 quoted lines

> +	cat >expect <<-EOF &&
> +	error: atomic push failed for ref refs/heads/noff. status: 2
> +	error: failed to push some refs to '"'"'dst'"'"'
> +	EOF
> +	test_i18ncmp expect actual

Another thing I forgot to say. This expects the exact phrasing of error message to stay the same, which is not really desirable. We might want to start quoting `refs/heads/noff` in the message like other messages often do, for example, and this test will have to match.

If you expect that the failure is not due to GPG (i.e. the updated code in 2/2 wants to fail before asking GPG to do anything), why not grep for what your "Fake gpg" says in the error output and make sure that message does not appear? That would make this test a lot more robust, I suspect.

> +'
> +
>  test_done