Re: [PATCH v2] upload-pack: allow stateless client EOF just prior to haves

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 31, 2020, 04:17 UTC
Message-ID: <xmqqv9er3u6l.fsf@gitster.c.googlers.com>
In-Reply-To: <CANo+1guedZiZVbnANsSPCiYbKWpJ_tjJ7vc04Ap7EVZzzp869A@mail.gmail.com>

Daniel Duvall <dan@mutual.io> writes:

Show 13 quoted lines

> On Fri, Oct 30, 2020 at 4:45 PM Junio C Hamano <gitster@pobox.com> wrote:
>>
>> >  t/t5705-upload-pack-stateless-shallow-eof.sh | 24 ++++++++++++++++++++
>> >  upload-pack.c                                | 13 ++++++++++-
>> >  2 files changed, 36 insertions(+), 1 deletion(-)
>> >  create mode 100755 t/t5705-upload-pack-stateless-shallow-eof.sh
>>
>> I'd rather see it folded in an existing test, if it makes sense.
>
> With v3 I've moved it into t/t5530-upload-pack-error.sh. That test
> file seemed to mostly contain errant cases, but I thought it might be
> close enough as this was previously an errant case. If there's a
> better place for it I'm happy to move it again.

5530 is good. It is not too big or full of unrelated tests, and it is about sanity in the low level protocol exchange.

Thanks.