git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] upload-pack: allow stateless client EOF just prior to haves

From
Daniel Duvall <dan@mutual.io>
Date
Oct 31, 2020, 02:42 UTC
Message-ID
<CANo+1guedZiZVbnANsSPCiYbKWpJ_tjJ7vc04Ap7EVZzzp869A@mail.gmail.com>
In-Reply-To
<xmqqzh4346sb.fsf@gitster.c.googlers.com>
On Fri, Oct 30, 2020 at 4:45 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 7 quoted lines
>
> >  t/t5705-upload-pack-stateless-shallow-eof.sh | 24 ++++++++++++++++++++
> >  upload-pack.c                                | 13 ++++++++++-
> >  2 files changed, 36 insertions(+), 1 deletion(-)
> >  create mode 100755 t/t5705-upload-pack-stateless-shallow-eof.sh
>
> I'd rather see it folded in an existing test, if it makes sense.

With v3 I've moved it into t/t5530-upload-pack-error.sh. That test file seemed to mostly contain errant cases, but I thought it might be close enough as this was previously an errant case. If there's a better place for it I'm happy to move it again.

Previous: Junio C HamanoNext: Junio C Hamano
Message 16 of 18 in “upload-pack: allow stateless client EOF just prior to haves”
  1. upload-pack: allow stateless client EOF just prior to havesDaniel Duvall, Oct 30, 2020
  2. Eric SunshineOct 30, 2020
  3. Daniel DuvallOct 30, 2020
  4. upload-pack: allow stateless client EOF just prior to havesDaniel Duvall, Oct 30, 2020
  5. Junio C HamanoOct 30, 2020
  6. Daniel DuvallOct 30, 2020
  7. Jeff KingOct 30, 2020
  8. Daniel DuvallOct 30, 2020
  9. Jeff KingOct 30, 2020
  10. Junio C HamanoNov 3, 2020
  11. Jeff KingNov 4, 2020
  12. Daniel DuvallNov 4, 2020
  13. Junio C HamanoNov 4, 2020
  14. upload-pack: allow stateless client EOF just prior to havesDaniel Duvall, Oct 30, 2020
  15. Junio C HamanoOct 30, 2020
  16. Daniel DuvallOct 31, 2020
  17. Junio C HamanoOct 31, 2020
  18. upload-pack: allow stateless client EOF just prior to havesDaniel Duvall, Oct 31, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.