Re: Reviewed-by given by celebrities (no subject matter expertise on Git development)

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 7, 2021, 20:57 UTC
Message-ID: <xmqqv98xyfrt.fsf@gitster.g>
In-Reply-To: <YG4U5phu1uXZe6Tn@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 10 quoted lines

> I don't usually post "me too" responses, since they are usually just
> noise. But I could not resist it here, for two reasons:
>
>   - this is such a nicely written summary of what "Reviewed-by" means in
>     our project that I think it deserves some praise. :)
>
>   - because it is ultimately about "what does Reviewed-by mean within
>     the Git project", there is some small value in having another
>     project member say "yes, that is exactly what I expect from it,
>     too"

Heh, thanks.

Are you hinting that some of what I wrote (with typofixes like s/arond/around/) should be inserted to SubmittingPatches or somewhere near it?

I am still scratching my head why "celebrities" were brought into the original question in the first place, but I can say that we do not discriminate against "celebrities" who review patches with prejudice like "that lady only plays a hacker on TV, and must know nothing to qualify to review our patches." Celebrities or not, once somebody demonstrates enough competence and earns reputation on this list, opinions by that person would count more than others.