git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Reviewed-by given by celebrities (no subject matter expertise on Git development)

From
Jeff King <peff@peff.net>
Date
Apr 7, 2021, 21:18 UTC
Message-ID
<YG4hpT5EL6jZp4Pq@coredump.intra.peff.net>
In-Reply-To
<xmqqv98xyfrt.fsf@gitster.g>
On Wed, Apr 07, 2021 at 01:57:10PM -0700, Junio C Hamano wrote:
Show 18 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> > I don't usually post "me too" responses, since they are usually just
> > noise. But I could not resist it here, for two reasons:
> >
> >   - this is such a nicely written summary of what "Reviewed-by" means in
> >     our project that I think it deserves some praise. :)
> >
> >   - because it is ultimately about "what does Reviewed-by mean within
> >     the Git project", there is some small value in having another
> >     project member say "yes, that is exactly what I expect from it,
> >     too"
> 
> Heh, thanks.
> 
> Are you hinting that some of what I wrote (with typofixes like
> s/arond/around/) should be inserted to SubmittingPatches or
> somewhere near it?

I would not be opposed to that, but I also do not want to create more work for you. :)

-Peff
Previous: Junio C Hamano
Message 5 of 5 in “Reviewed-by given by celebrities (no subject matter expertise on Git development)”
  1. Bagas SanjayaApr 2, 2021
  2. Junio C HamanoApr 4, 2021
  3. Jeff KingApr 7, 2021
  4. Junio C HamanoApr 7, 2021
  5. Jeff KingApr 7, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.