Re: Re* [PATCH v4] userdiff: improve java hunk header regex

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 11, 2021, 16:04 UTC
Message-ID: <xmqqv94c9ddm.fsf@gitster.g>
In-Reply-To: <157a0c35-1c82-9a2e-3bcd-ae6059ec71bd@kdbg.org>

Johannes Sixt <j6t@kdbg.org> writes:

Show 8 quoted lines

>> + * When writing or updating patterns, assume that the contents these
>> + * patterns are applied to are syntactically correct.  You do not have
>> + * to implement all syntactical corner cases---the patterns have to be
>> + * sufficiently permissive.
>> + */
>
> IMO, as written, the comment falls short of suggesting that patterns can
> be simple. How about appending "and can be simple"?

    The patterns can be simple without implementing all syntactical
    corner cases, as long as they are sufficiently permissive.

perhaps?

Thanks.