Re: [PATCH v5 2/2] gc: introduce `gc.recentObjectsHook`

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 12, 2023, 21:14 UTC
Message-ID: <xmqqv8fs8jsu.fsf@gitster.g>
In-Reply-To: <kl6lwn0cfbyh.fsf@chooglen-macbookpro.roam.corp.google.com>

Glen Choo <chooglen@google.com> writes:

Show 7 quoted lines

> Taylor Blau <me@ttaylorr.com> writes:
>
>> When performing a garbage collection operation on a repository with
>> unreachable objects, Git makes its decision on what to do with those
>> object(s) bed on how recent the objects are or not. Generally speaking,
>
> s/bed/based/ ?

Indeed.  Also "or not" sounds a bit extraneous.

Show 5 quoted lines

>> +		if (parse_oid_hex(buf.buf, &oid, &rest) || *rest) {
>> +			ret = error(_("invalid extra cruft tip: '%s'"), buf.buf);
>
> To be consistent with the other error message, perhaps s/extra cruft
> tip/additional recent object/?

Sharp eyes.

> Aside from those trivial points, everything looks good.

Thanks for reviewing (and writing).