Re: [PATCH v3 0/2] pack-objects: introduce `pack.extraRecentObjectsHook`

From: Taylor Blau <me@ttaylorr.com>
Date: May 11, 2023, 23:48 UTC
Message-ID: <ZF1+5PSgo3zAOYS+@nand.local>
In-Reply-To: <xmqqttwisaj5.fsf@gitster.g>

On Thu, May 11, 2023 at 04:39:26PM -0700, Junio C Hamano wrote:

Show 11 quoted lines

> Taylor Blau <me@ttaylorr.com> writes:
>
> > Here is a reworked version of the patch which introduced a new
> > configuration `pack.extraCruftTips` to keep additional objects from
> > pruning during a cruft pack-generating GC.
> >
> > The third round was significantly more complicated than necessary, and I
>
> Hopefully you just meant "the previous round"; in a follow-up you
> mention that this is v4 and not v3, which is also a good explanation
> for that "third round was too complex".

Yes, this series being the true fourth round, I was referring to the version I sent in:

  https://lore.kernel.org/git/27a7f16aab35b5cac391d9831aadb0f2e2146313.1683151485.git.me@ttaylorr.com/

...which this version is significantly less complicated than.

Show 9 quoted lines

> > I am hopeful that others think this version is in a good spot. As in
> > earlier rounds, I would appreciate an extra careful review on this
> > topic, because of the changing default I mentioned earlier.
> >
> > Thanks in advance for your review.
>
> Thanks for working on it.  I am in the process of pushing out
> today's integration cycle already, so this topic will have to wait
> until tomorrow's, though.

No problem. Happy merging ;-).

Thanks, Taylor