Re: [PATCH 0/2] advise about force-pushing as an alternative to reconciliation

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 4, 2023, 21:44 UTC
Message-ID: <xmqqv8ez4ajb.fsf@gitster.g>
In-Reply-To: <c3c36f93-3fc5-7f7d-1c24-e6925729cc96@gmail.com>

Phillip Wood <phillip.wood123@gmail.com> writes:

Show 6 quoted lines

> Hi Alex
>
> On 02/07/2023 21:08, Alex Henrie wrote:
>> Many times now, I have seen novices do the following:
>> 1. Start work on their own personal topic branch
>> 2. Push the branch to origin

And did this succeed, or did this fail? I'd assume that it failed, because othrewise you would not be rebasing your work done in #1 on top of what the central repository has. Also ...

>> 3. Rebase the branch onto origin/master

... the user's better have done "git fetch" to update origin/master before this step. And that means this can just be done with "git pull --rebase" (or you may already have configured pull to do so).

In any case, assuming that this was indeed the intention of the user, i.e. the user never wanted to discard the changes made in the central repository (presumably by others)...

>> 4. Try to push again, but Git says they need to pull

... if this happened, it is because somebody else pushed in the meantime, right? Then ...

>> 5. Pull and make a mess trying to reconcile the older topic branch with
>>     the rebased topic branch

... this means that somebody else's work was something that overlapped with what you did in #1, and then you do want to clean up the mess carefully, so that you do not lose the work by that somebody else. So ...

>> Help avoid this mistake by giving advice that mentions
>> force-pushing,

... why would it possibly be a good idea to suggest force pushing, which discards other's work? I do not quite understand.

Show 12 quoted lines

> I don't think we want to be advising users to force push. For the case
> you mention above I think it would be much safer to advise them to use
>
> 	git push --force-if-includes
>
> In the absence of background fetches even
>
> 	git push --force-with-lease
>
> is still safer than
>
> 	git push --force

Absolutely. git push --force-with-lease=$(git merge-base HEAD origin/master) or something, perhaps, would be even better.

Thanks.