Re: [PATCH v3 1/2] remote: advise about force-pushing as an alternative to reconciliation

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 11, 2023, 00:55 UTC
Message-ID: <xmqqsf9v2roa.fsf@gitster.g>
In-Reply-To: <CAMMLpeSwadTcd+z0-J1t=vUgz0wFiVaE5KaT-Wy1cckT3=fFGQ@mail.gmail.com>

Alex Henrie <alexhenrie24@gmail.com> writes:

Show 20 quoted lines

> On Sat, Jul 8, 2023 at 7:38 PM Junio C Hamano <gitster@pobox.com> wrote:
>>
>> Alex Henrie <alexhenrie24@gmail.com> writes:
>>
>> > I agree, showing this message in the middle of `git commit` is not
>> > ideal. However, that's a separate issue that can be fixed later; it's
>> > not part of the problem I'm trying to solve in this series.
>>
>> That is debatable.  Even "by the way you can pull and reconcile
>> early before you have fully finished working on the topic and are
>> ready to push back" is irrelevant during `git commit`.  "Reconciling
>> the differences is not the only way to deal with divergence; you may
>> decide to simply discard what they have with push --force" is even
>> less relevant at that time.  So it seems to be very much an integral
>> part of the problem you are tackling, at least to me.
>
> I thought we just agreed that we don't need to mention force-pushing
> in this particular message? I guess you're saying that we'd still be
> over-encouraging `git pull` if we don't remove this message from `git
> commit` altogether?

I do not think so.

I was saying that, when the user during `git commit` is wondering what to write in the log message of the commit they are working on (which may not yet make the current branch ready to be pushed to or integrated with the remote), the user is not ready to even choose between "forcing push to overwrite" and "integrate and then push".

It can be fixed later, but it is a part of "how to avoid giving confusing message to users, especially the new ones" theme. After all, "do not make it sound like they always have to integrate" is how you started this journey, no?

Thanks.