git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] t/README: document how to loop around test cases

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 22, 2024, 02:12 UTC
Message-ID
<xmqqv85f3tga.fsf@gitster.g>
In-Reply-To
<ZfzncGTNVwR8BrhR@tanuki>
Patrick Steinhardt <ps@pks.im> writes:
Show 14 quoted lines
> Hum, good point. How about the below diff? Will reroll the patch series
> if that looks good to you.
>
> --- a/t/README
> +++ b/t/README
> @@ -736,7 +736,8 @@ The "do's:"
>         done
>
>    Note that while the test title uses double quotes ("), the test body
> -  should continue to use single quotes ('). The loop variable will be
> +  should continue to use single quotes (') to avoid breakage in case the
> +  values contain e.g. quoting characters. The loop variable will be
>    accessible regardless of the single quotes as the test body is passed
>    to `eval`.
Wow, simple and effective.
Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 7 of 13 in “t7800: fix quoting of looped test bodies”
  1. 0/3 t7800: fix quoting of looped test bodiesPatrick Steinhardt, Mar 21, 2024
  2. 1/3 t7800: improve test descriptions with empty argumentsPatrick Steinhardt, Mar 21, 2024
  3. 2/3 t7800: use single quotes for test bodiesPatrick Steinhardt, Mar 21, 2024
  4. 3/3 t/README: document how to loop around test casesPatrick Steinhardt, Mar 21, 2024
  5. Junio C HamanoMar 21, 2024
  6. Patrick SteinhardtMar 22, 2024
  7. Junio C HamanoMar 22, 2024
  8. Patrick SteinhardtMar 21, 2024
  9. 0/3 t7800: fix quoting of looped test bodiesPatrick Steinhardt, Mar 22, 2024
  10. 1/3 t7800: improve test descriptions with empty argumentsPatrick Steinhardt, Mar 22, 2024
  11. 2/3 t7800: use single quotes for test bodiesPatrick Steinhardt, Mar 22, 2024
  12. 3/3 t/README: document how to loop around test casesPatrick Steinhardt, Mar 22, 2024
  13. Junio C HamanoMar 22, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.