git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/3] t7800: fix quoting of looped test bodies

From
Patrick Steinhardt <ps@pks.im>
Date
Mar 22, 2024, 02:23 UTC
Message-ID
<cover.1711074118.git.ps@pks.im>
In-Reply-To
<cover.1711028473.git.ps@pks.im>
Hi,

this is the second version of my patch series that aims to address some issues with looping around `test_expect_success` in t7800.

Changes compared to v1:
    - Fixed indentation of a paragraph in "t/README".
    - Added a clarification why one wants to use single quotes to
      "t/README".
Thanks!
Patrick
Patrick Steinhardt (3):
  t7800: improve test descriptions with empty arguments
  t7800: use single quotes for test bodies
  t/README: document how to loop around test cases
 t/README            | 20 ++++++++++++++++++++
 t/t7800-difftool.sh | 40 ++++++++++++++++++++--------------------
 2 files changed, 40 insertions(+), 20 deletions(-)
Range-diff against v1:
1:  fd37c29319 = 1:  fd37c29319 t7800: improve test descriptions with empty arguments
2:  a4ca974397 = 2:  a4ca974397 t7800: use single quotes for test bodies
3:  326fb79650 ! 3:  f83b710208 t/README: document how to loop around test cases
    @@ t/README: The "do's:"
     +		'
     +	done
     +
    -+  Note that while the test title uses double quotes ("), the test body
    -+  should continue to use single quotes ('). The loop variable will be
    -+  accessible regardless of the single quotes as the test body is passed
    -+  to `eval`.
    ++   Note that while the test title uses double quotes ("), the test body
    ++   should continue to use single quotes (') to avoid breakage in case the
    ++   values contain e.g. quoting characters. The loop variable will be
    ++   accessible regardless of the single quotes as the test body is passed
    ++   to `eval`.
     +
      
      And here are the "don'ts:"
-- 
2.44.0
Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 9 of 13 in “t7800: fix quoting of looped test bodies”
  1. 0/3 t7800: fix quoting of looped test bodiesPatrick Steinhardt, Mar 21, 2024
  2. 1/3 t7800: improve test descriptions with empty argumentsPatrick Steinhardt, Mar 21, 2024
  3. 2/3 t7800: use single quotes for test bodiesPatrick Steinhardt, Mar 21, 2024
  4. 3/3 t/README: document how to loop around test casesPatrick Steinhardt, Mar 21, 2024
  5. Junio C HamanoMar 21, 2024
  6. Patrick SteinhardtMar 22, 2024
  7. Junio C HamanoMar 22, 2024
  8. Patrick SteinhardtMar 21, 2024
  9. 0/3 t7800: fix quoting of looped test bodiesPatrick Steinhardt, Mar 22, 2024
  10. 1/3 t7800: improve test descriptions with empty argumentsPatrick Steinhardt, Mar 22, 2024
  11. 2/3 t7800: use single quotes for test bodiesPatrick Steinhardt, Mar 22, 2024
  12. 3/3 t/README: document how to loop around test casesPatrick Steinhardt, Mar 22, 2024
  13. Junio C HamanoMar 22, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.