git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH 1/2] rebase, am: add --reviewby option

From
Junio C Hamano <gitster@pobox.com>
Date
May 6, 2025, 18:07 UTC
Message-ID
<xmqqv7qdk3yl.fsf@gitster.g>
In-Reply-To
<196a5aceb00.fdc2d9ff187843.3547183335386278718@linux.beauty>
Li Chen <me@linux.beauty> writes:
> From: Li Chen <chenl311@chinatelecom.cn>
>
> Introduce a new `--reviewby` flag to `git rebase` and `git am` that appends a

Shouldn't this (and possibly the other one, I didn't look at the patch text) be using the internal machinery used by interpret-trailers so that we can do the usual "do not duplicated existing ones", "append only at the last one is different" etc.?

I also do not think we want to see one option (like the above) for each trailer elements (like "Reviewed-by") that is commonly used, which would lead us to adding "--helped-by", "--acked-by", etc. to complement this one.

Previous: Li ChenNext: Li Chen
Message 3 of 16 in “rebase: support --trailer and add --reviewby”
  1. 0/2 rebase: support --trailer and add --reviewbyLi Chen, May 6, 2025
  2. 1/2 rebase, am: add --reviewby optionLi Chen, May 6, 2025
  3. Junio C HamanoMay 6, 2025
  4. Li ChenMay 7, 2025
  5. Phillip WoodMay 7, 2025
  6. Phillip WoodMay 7, 2025
  7. Kristoffer HaugsbakkMay 7, 2025
  8. Phillip WoodMay 7, 2025
  9. Junio C HamanoMay 7, 2025
  10. 2/2 rebase: support --trailerLi Chen, May 6, 2025
  11. Phillip WoodMay 8, 2025
  12. Li ChenMay 8, 2025
  13. phillip.wood123@gmail.comMay 8, 2025
  14. Phillip WoodMay 8, 2025
  15. Li ChenMay 16, 2025
  16. Phillip WoodMay 16, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.