Re: [RFC PATCH 1/2] rebase, am: add --reviewby option
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 6, 2025, 18:07 UTC
- Message-ID
- <xmqqv7qdk3yl.fsf@gitster.g>
- In-Reply-To
- <196a5aceb00.fdc2d9ff187843.3547183335386278718@linux.beauty>
Li Chen <me@linux.beauty> writes:
> From: Li Chen <chenl311@chinatelecom.cn> > > Introduce a new `--reviewby` flag to `git rebase` and `git am` that appends a
Shouldn't this (and possibly the other one, I didn't look at the patch text) be using the internal machinery used by interpret-trailers so that we can do the usual "do not duplicated existing ones", "append only at the last one is different" etc.?
I also do not think we want to see one option (like the above) for each trailer elements (like "Reviewed-by") that is commonly used, which would lead us to adding "--helped-by", "--acked-by", etc. to complement this one.