Re: [RFC PATCH 2/2] rebase: support --trailer

From: Phillip Wood <phillip.wood123@gmail.com>
Date: May 8, 2025, 16:29 UTC
Message-ID: <98415c84-a5ab-4bf0-b361-dd60ff3e7dd2@gmail.com>
In-Reply-To: <196b09c1324.fba686d21234508.1995945025408421751@linux.beauty>

Hi Li

On 08/05/2025 16:55, Li Chen wrote:

Show 9 quoted lines

>   ---- On Thu, 08 May 2025 22:17:17 +0800  Phillip Wood <phillip.wood123@gmail.com> wrote ---
> 
>   > I've left some comments on the changes to builtin/rebase.c and the
>   > tests, I've skipped the changes to sequencer.c for now as they'll have
>   > to be updated to avoid forking "git interpret-trailers"
> 
> Thanks for all your great reviews!
> 
> I'll address all your reviews in next version.

I forgot to say earlier that if you have any questions or queries about my review or the trailer code do feel free to ask.

Best Wishes

Phillip