Re: [PATCH v3 0/2] apply: set file mode when --reverse creates a deleted file
Mark Mentovai <mark@chromium.org> writes:
Show 12 quoted lines
> Changes from v2:
> * test_file_mode_common correctly fails when requested to verify the
> presence of a file (by nonzero mode argument) that is actually absent.
> * Test setup establishes tags at appropriate checkpoints with git tag,
> and tests restore those checkpoints with git reset --hard, making
> tests less sensitive to execution order and to the success of previous
> tests.
> * test_file_mode_common accepts full 6-digit file modes instead of
> 4-digit ones, and uses 000000 for absent files (as git diff --raw
> does) instead of an empty string.
> * File presence is assured with >f as opposed to touch f. Minor style
> * fix at the point of test_file_mode_common's declaration.
Nicely done. Thanks.
Will queue.