Re: [PATCH v2 1/2] t4129: test that git apply warns for unexpected mode changes

From: Junio C Hamano <gitster@pobox.com>
Date: May 23, 2025, 23:32 UTC
Message-ID: <xmqqmsb2vr6z.fsf@gitster.g>
In-Reply-To: <20250523172154.93810-2-mark@chromium.org>

Mark Mentovai <mark@chromium.org> writes:

Show 34 quoted lines

> There is no test covering what commit 01aff0a (apply: correctly reverse
> patch's pre- and post-image mode bits, 2023-12-26) addressed. Prior to
> that commit, git apply was erroneously unaware of a file's expected mode
> while reverse-patching a file whose mode was not changing.
>
> Add the missing test coverage to assure that git apply is aware of the
> expected mode of a file being patched when the patch does not indicate
> that the file's mode is changing. This is achieved by arranging a file
> mode so that it doesn't agree with patch being applied, and checking git
> apply's output for the warning it's supposed to raise in this situation.
> Test in both reverse and normal (forward) directions.
>
> Signed-off-by: Mark Mentovai <mark@chromium.org>
> ---
>  t/t4129-apply-samemode.sh | 61 +++++++++++++++++++++++++++++++++++----
>  1 file changed, 56 insertions(+), 5 deletions(-)
>
> diff --git a/t/t4129-apply-samemode.sh b/t/t4129-apply-samemode.sh
> index 2149ad5da44c..082e56db651e 100755
> --- a/t/t4129-apply-samemode.sh
> +++ b/t/t4129-apply-samemode.sh
> @@ -102,15 +102,23 @@ test_expect_success POSIXPERM 'do not use core.sharedRepository for working tree
>  	)
>  '
>  
> +test_file_mode_staged () {
> +	git ls-files --stage -- "$2" >ls-files-output &&
> +	test_grep "^10$1 " ls-files-output
> +}
> +
> +test_file_mode_HEAD () {
> +	git ls-tree HEAD -- "$2" >ls-tree-output &&
> +	test_grep "^10$1 " ls-tree-output
> +}

The script is about testing executable bits, so it is fine that the above cannot be used to expect a symbolic link (if we wanted to support it, we'd just take the whole 100644 vs 120000 without support to let the caller give abbreviated input).

But then it is curious that this asks the caller to say 0755 vs 0644, not 755 vs 644, which would be sufficient.

Show 27 quoted lines

>  test_expect_success 'git apply respects core.fileMode' '
>  	test_config core.fileMode false &&
>  	echo true >script.sh &&
>  	git add --chmod=+x script.sh &&
> -	git ls-files -s script.sh >ls-files-output &&
> -	test_grep "^100755" ls-files-output &&
> +	test_file_mode_staged 0755 script.sh &&
>  	test_tick && git commit -m "Add script" &&
> -	git ls-tree -r HEAD script.sh >ls-tree-output &&
> -	test_grep "^100755" ls-tree-output &&
> +	test_file_mode_HEAD 0755 script.sh &&
>  
>  	echo true >>script.sh &&
>  	test_tick && git commit -m "Modify script" script.sh &&
> @@ -126,7 +134,50 @@ test_expect_success 'git apply respects core.fileMode' '
>  	test_grep ! "has type 100644, expected 100755" err &&
>  
>  	git apply --cached patch 2>err &&
> -	test_grep ! "has type 100644, expected 100755" err
> +	test_grep ! "has type 100644, expected 100755" err &&
> +	git reset --hard
> +'
> +
> +test_expect_success 'setup: git apply [--reverse] warns about incorrect file modes' '
> +	test_config core.fileMode false &&
> +
> +	touch mode_test &&

Use of "touch" makes the readers wonder a few unnecessary and irrelevant things, like "does this test care about the timestamp of this file?", "did mode_test file exist before?", and "what contents did mode_test file have that the 'touch' tries to preserve while updating the timestamp?"

Saying

	>mode_test &&

is much better here in this context. It makes it clear that it does not matter if the file did or did not exist before, the only thing we care about is it exists as an empty file.

Show 13 quoted lines

> +	git add --chmod=-x mode_test &&
> +	test_file_mode_staged 0644 mode_test &&
> +	test_tick && git commit -m "add mode_test" &&
> +	test_file_mode_HEAD 0644 mode_test &&
> +
> +	echo content >>mode_test &&
> +	test_tick && git commit -m "append to mode_test" mode_test &&
> +	test_file_mode_HEAD 0644 mode_test &&
> +
> +	git format-patch -1 --stdout >patch &&
> +	test_grep "^index .* 100644$" patch &&
> +
> +	git add --chmod=+x mode_test &&

Very portable way to add an executable file. Would work regardless of the filesystem. Very nice.

Show 26 quoted lines

> +	test_file_mode_staged 0755 mode_test &&
> +	test_tick && git commit -m "make mode_test executable" &&
> +	test_file_mode_HEAD 0755 mode_test
> +'
> +
> +test_expect_success 'git apply --reverse warns about incorrect file modes' '
> +	test_config core.fileMode false &&
> +
> +	git apply --index --reverse patch 2>err &&
> +	test_grep "has type 100755, expected 100644" err &&
> +	test_file_mode_staged 0755 mode_test &&
> +	test_tick && git commit -m "undo append" &&
> +	test_file_mode_HEAD 0755 mode_test
> +'
> +
> +test_expect_success 'git apply warns about incorrect file modes' '
> +	test_config core.fileMode false &&
> +
> +	git apply --index patch 2>err &&
> +	test_grep "has type 100755, expected 100644" err &&
> +	test_file_mode_staged 0755 mode_test &&
> +	test_tick && git commit -m "redo append" &&
> +	test_file_mode_HEAD 0755 mode_test
>  '
>  
>  test_expect_success POSIXPERM 'patch mode for new file is canonicalized' '