Re: [PATCH] imap-send: use ASN1_STRING_length
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 12, 2026, 17:18 UTC
- Message-ID
- <xmqqv77696sf.fsf@gitster.g>
- In-Reply-To
- <20261012151748.62723-1-aniketgupta3001@gmail.com>
Aniket Gupta <aniketgupta3001@gmail.com> writes:
Show 13 quoted lines
> Hello Xiangfei,
>
>> + int pat_len = ASN1_STRING_length(asn1_str);
>
> It seems that with OpenSSL 4.1.0-beta2 this is deprecated
> (ASN1_STRING_get_length() is the replacement), so it warns, and
> fails with DEVELOPER=1. The patch adds a second use at the error
> message. Beat Bolli has a series from 7 Sept ("imap-send: future
> proofing and two correctness fixes") that also touches
> host_matches(), maybe we can check how the two can fit together?
>
> Thanks,
> Aniket[jch: rewrapped long unreadable lines]
That topic also needs rework, unfortunately.
https://lore.kernel.org/git/20260907211210.2621693-1-dev+git@drbeat.li/
I guess we can salvage the patches 1 and 2 with fairly trivial changes, namely with the style fix in [1/3], and pointer arithmetic that breaks later free() fix in [2/3]. I am not sure how involved it would be to fix [3/3] in such a way suggested by brian in the thread.
Thanks for reminding us of the old thread.