Re: [PATCH] imap-send: use ASN1_STRING_length
- From
- Xiangfei Ding <xfding@google.com>
- Date
- Oct 19, 2026, 08:48 UTC
- Message-ID
- <CABtdbsmUU-J+Ytdno36hBH2acjT_1Ee6dQ2DeCAXhwaZ910Paw@mail.gmail.com>
- In-Reply-To
- <5d5dfa51-abc3-4a8f-badd-48ee398ad73f@drbeat.li>
Dear all,
Ah sorry, this is buried in my mailbox. Many apologies for the late reply.
> On 12.10.2026 19:18, Junio C Hamano wrote:
>> What are these two separate sign-off lines doing?
I contributed to the kernel under the other email address. I shall use this email address for future correspondence and sign-offs to avoid confusion.
I have finished reviewing the patch from Beat. Since I really prefer that approach, I will retract this patch.
Have a nice day, git.
Best Regards, Xiangfei Ding
Signed-off-by: Xiangfei Ding <xfding@google.com>
On Mon, Oct 12, 2026 at 10:09 PM Beat Bolli <dev+git@drbeat.li> wrote:
Show 37 quoted lines
>
> On 12.10.2026 19:18, Junio C Hamano wrote:
> > Aniket Gupta <aniketgupta3001@gmail.com> writes:
> >
> >> Hello Xiangfei,
> >>
> >>> + int pat_len = ASN1_STRING_length(asn1_str);
> >>
> >> It seems that with OpenSSL 4.1.0-beta2 this is deprecated
> >> (ASN1_STRING_get_length() is the replacement), so it warns, and
> >> fails with DEVELOPER=1. The patch adds a second use at the error
> >> message. Beat Bolli has a series from 7 Sept ("imap-send: future
> >> proofing and two correctness fixes") that also touches
> >> host_matches(), maybe we can check how the two can fit together?
> >>
> >> Thanks,
> >> Aniket
> >
> > [jch: rewrapped long unreadable lines]
> >
> > That topic also needs rework, unfortunately.
> >
> > https://lore.kernel.org/git/20260907211210.2621693-1-dev+git@drbeat.li/
> >
> > I guess we can salvage the patches 1 and 2 with fairly trivial
> > changes, namely with the style fix in [1/3], and pointer arithmetic
> > that breaks later free() fix in [2/3]. I am not sure how involved
> > it would be to fix [3/3] in such a way suggested by brian in the
> > thread.
> >
> > Thanks for reminding us of the old thread.
> >
>
> I'm working on a new branch that uses OpenSSL's built-in hostname
> verification. All this low level ASN.1 code will disappear as a result.
>
> Best regards, Beat