git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git diff-tree commit detail bug in 2.0.2 and 2.0.3

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 28, 2014, 17:32 UTC
Message-ID
<xmqqtx614cea.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20140728103504.GB10737@peff.net>
Jeff King <peff@peff.net> writes:
Show 23 quoted lines
> On Mon, Jul 28, 2014 at 07:42:16PM +1000, Bryan Turner wrote:
>
>> Running a git bisect between v2.0.1, which does not manifest this
>> issue, and v2.0.2 fingers the following commit:
>> bturner@ubuntu:~/Development/oss/git/git$ git bisect bad
>> c1b3c71f4b4571abb2b2a457122fd100dc9f7eb0 is the first bad commit
>> commit c1b3c71f4b4571abb2b2a457122fd100dc9f7eb0
>> Author: Jeff King <peff@peff.net>
>> Date:   Tue Jun 10 17:43:02 2014 -0400
>> 
>>     commit: convert commit->buffer to a slab
>
> I haven't reproduced here yet, but this is almost certainly the bug
> where lookup_unknown_object causes a bogus commit->index field (and
> prior to the commit you found, diff-tree did not use commit->index).
>
> The series that Junio has in jk/alloc-commit-id should fix the problem
> (it's in master already, and slated for v2.1.0).
>
> Junio, we should consider a v2.0.4 with that series, I think. This is a
> pretty serious regression in diff-tree (I didn't even realize that the
> buffer-slab work went into the maint series; that may have been a little
> ambitious).

Or v2.0.4 without that series, which is how we usually do things, but let me see if jk/alloc-commit-id is easily applicable there first.

Thanks.
Previous: Jeff KingNext: Jeff King
Message 8 of 14 in “git diff-tree commit detail bug in 2.0.2 and 2.0.3”
  1. Bryan TurnerJul 28, 2014
  2. Ramsay JonesJul 28, 2014
  3. Jeff KingJul 28, 2014
  4. Jeff KingJul 28, 2014
  5. Bryan TurnerJul 28, 2014
  6. Junio C HamanoJul 28, 2014
  7. Jeff KingJul 28, 2014
  8. Junio C HamanoJul 28, 2014
  9. Jeff KingJul 28, 2014
  10. Jeff KingJul 28, 2014
  11. Junio C HamanoJul 28, 2014
  12. Junio C HamanoJul 29, 2014
  13. Bryan TurnerJul 29, 2014
  14. Jeff KingJul 29, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.