git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git diff-tree commit detail bug in 2.0.2 and 2.0.3

From
Bryan Turner <bturner@atlassian.com>
Date
Jul 29, 2014, 01:06 UTC
Message-ID
<CAGyf7-HK74YuqhrRDJ46qti17UNAd6Bp6if4y+ZwUV_PZs2ujQ@mail.gmail.com>
In-Reply-To
<xmqqegx53txe.fsf@gitster.dls.corp.google.com>
On Tue, Jul 29, 2014 at 10:11 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 23 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
>>>> Yeah, I'm fine with a straight revert, too (I think it is fine to keep
>>>> in master, though). I think jk/alloc-commit-id is built right on top of
>>>> the original commit-slab topic, so it should be easy to do either way.
>>>>
>>>> Thanks for dealing with it.
>>>
>>> Whatever we do, perhaps it is worth applying the test below on top?
>>
>> Yeah, thanks.  I think that is a good idea.  I was preparing a patch
>> to tuck your minimum reproduction at the end of 4202, but your version
>> and placement makes good sense.
>
> OK, I pushed out updated 'maint' and 'master'.  The former merges
> a rebased version of jk/alloc-commit-id in to make the "reorganize
> the way we manage the in-core commit data" topic, and the latter
> reverts the "Use SSE to micro-optimize a leaf function to check the
> format of a ref string".
>
> Please give them some quick sanity check.
>
> Thanks.

Thanks both of you; I appreciate your efforts! I've run my suite of tests against the tips of master and maint and all 681 pass for each. Looks good to me.

Best regards, Bryan Turner

Previous: Junio C HamanoNext: Jeff King
Message 13 of 14 in “git diff-tree commit detail bug in 2.0.2 and 2.0.3”
  1. Bryan TurnerJul 28, 2014
  2. Ramsay JonesJul 28, 2014
  3. Jeff KingJul 28, 2014
  4. Jeff KingJul 28, 2014
  5. Bryan TurnerJul 28, 2014
  6. Junio C HamanoJul 28, 2014
  7. Jeff KingJul 28, 2014
  8. Junio C HamanoJul 28, 2014
  9. Jeff KingJul 28, 2014
  10. Jeff KingJul 28, 2014
  11. Junio C HamanoJul 28, 2014
  12. Junio C HamanoJul 29, 2014
  13. Bryan TurnerJul 29, 2014
  14. Jeff KingJul 29, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.