Re: [PATCH v2 1/4] apply: reject input that touches outside $cwd

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 3, 2015, 21:23 UTC
Message-ID: <xmqqtwz2pu4c.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20150203210140.GA20594@peff.net>

Jeff King <peff@peff.net> writes:

> Right, I do not think these tests will _fail_ when the filesystem does
> not support symlinks. But nor are they actually testing anything
> interesting. They would pass on such a system even without your patch,
> as we would fail to apply even the symlink creation part of the patch.

I thought we write out the contents of the symbolic link as a regular file on such a filesystem, and as long as we do not expect "test -h expected-to-be-symlink-we-just-created" to succeed we would be fine.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.